Conversation
jacob720
force-pushed
the
mx_bluesky_1494_use_config_server_for_undulator
branch
from
20ccd5b to
3df99f3
Compare
jacob720
changed the title
jacob720
force-pushed
the
mx_bluesky_1494_use_config_server_for_undulator
branch
from
2cc6d15 to
f7c7993
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 288 288
Lines 10937 10939 +2
=======================================
+ Hits 10843 10845 +2
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| self.config_server = ConfigServer(url="https://daq-config.diamond.ac.uk") | ||
|
|
There was a problem hiding this comment.
I am not sure if this hardcoded config server is a good solution long term. I understand that it works fine now, but what if for some reason you need to divert your config server to a different endpoint - you would have to change the path here.
It feels like we need some king of an interface or a lookuptable provider which should probably be configured separately.
There was a problem hiding this comment.
Snap! I think my comment at #1773 (comment) is basically the same thing. I think we should define it in the ixx.py files like we do for e.g. a path provider
There was a problem hiding this comment.
yep, agreed - in an even broader perspective I don't think we should need daq-config-server as a dependency - but that's for later development DiamondLightSource/daq-config-server#157
3 participants
Fixes DiamondLightSource/mx-bluesky#1494
Required by DiamondLightSource/mx-bluesky#1497
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}